[libcxx-commits] [PATCH] D126119: [libc++] Enable more warnings in the test suite

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik marked an inline comment as done.
philnik added inline comments.


================
Comment at: libcxx/test/std/concepts/concepts.lang/concept.constructible/constructible_from.compile.pass.cpp:109-111
-  test<void (Empty::*)(const int&) throw()>();
-  test<void (Empty::*)(const int&) throw(),
-       void(Empty::*)(const int&) noexcept(true)>();
----------------
Mordante wrote:
> philnik wrote:
> > @Mordante These test-cases look completely redundant to me. Do you know why you added them?
> What do you mean with redundant?
Aren't `throw()` and `noexcept` specifications indistinguishable? (Same for `noexcept` and `noexcept(true)`, but these don't produce warnings)


================
Comment at: libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp:26
     std::quick_exit(0);
-    return 0;
 }
----------------
Mordante wrote:
> Not your change, but it looks like we're not testing anything in this test.
I'll add an `assert(false)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126119/new/

https://reviews.llvm.org/D126119