[libcxx-commits] [PATCH] D126592: [libc++] DO NOT REVIEW chrono formatting

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 28 03:45:30 PDT 2022


Mordante created this revision.
Herald added subscribers: mstorsjo, arphaman, arichardson, mgorny.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This is an incomplete not yet ready for review version of the code.

Since the output of these formatters are locale dependant it's expected
to fail on a lot of non-Linux platforms. There the list of CI's used has
been limited. There's no need to test every iteration of this patch on
all CI's.

It's intended to split this review in smaller parts for its real review.

Depends on D125606 <https://reviews.llvm.org/D125606>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126592

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__chrono/formatter.h
  libcxx/include/__chrono/ostream.h
  libcxx/include/__chrono/parser_std_format_spec.h
  libcxx/include/__chrono/statically_widen.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/chrono
  libcxx/include/module.modulemap
  libcxx/test/libcxx/private_headers.verify.cpp
  libcxx/test/libcxx/utilities/format/format.formatter/format.formatter.spec/formattable.compile.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.day/time.cal.day.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.year/time.cal.year.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/op.sys_days.pass.cpp
  libcxx/test/std/time/time.clock/time.clock.file/consistency.pass.cpp
  libcxx/test/std/time/time.clock/time.clock.system/ostream.pass.cpp
  libcxx/test/std/time/time.duration/time.duration.nonmember/ostream.pass.cpp
  libcxx/test/std/time/time.hms/time.hms.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.syn/formatter.day.pass.cpp
  libcxx/test/std/time/time.syn/formatter.duration.pass.cpp
  libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp
  libcxx/test/std/time/time.syn/formatter.month.pass.cpp
  libcxx/test/std/time/time.syn/formatter.month_day.pass.cpp
  libcxx/test/std/time/time.syn/formatter.month_day_last.pass.cpp
  libcxx/test/std/time/time.syn/formatter.month_weekday.pass.cpp
  libcxx/test/std/time/time.syn/formatter.sys_time.pass.cpp
  libcxx/test/std/time/time.syn/formatter.weekday.pass.cpp
  libcxx/test/std/time/time.syn/formatter.weekday_index.pass.cpp
  libcxx/test/std/time/time.syn/formatter.weekday_last.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year_month.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year_month_day.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year_month_day_last.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year_month_weekday.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year_month_weekday_last.pass.cpp
  libcxx/test/std/time/time.syn/formatter_tests.h
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/types.compile.pass.cpp
  libcxx/utils/ci/buildkite-pipeline.yml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126592.432709.patch
Type: text/x-patch
Size: 423483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220528/8f31793f/attachment-0001.bin>


More information about the libcxx-commits mailing list