[libcxx-commits] [PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

[James Nagurne via Phabricator via libcxx-commits]

JamesNagurne added a comment.

In D121838#3543421 <https://reviews.llvm.org/D121838#3543421>, @JamesNagurne wrote:

> After some investigation, I found that we did not set LLVM_INCLUDE_TESTS from the top-level project. This seems like an oversight because we build the test-depends (and check-all) regularly.
> After seeing LLVM_INCLUDE_TESTS to ON, the builds worked.
>
> This commit cleaned things up and exposed that mistake.

Sorry, this was a false positive. Building the 'test-depends' target still shows the LLVM build system telling the runtimes to build 'runtimes-test-depends', which is not defined in those ExternalProjects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121838/new/

https://reviews.llvm.org/D121838