[libcxx-commits] [PATCH] D126478: [runtimes] Officially deprecate the legacy testing configuration system

Fri May 27 10:16:43 PDT 2022

ldionne added a comment.

In D126478#3541693 <https://reviews.llvm.org/D126478#3541693>, @vvereschaka wrote:

> @ldionne , 
> I have checked out our cmake cache for win-to-linux cross builds and I found that we already use the "new-style" test configuration files all libs accordingly: `llvm-libc++-static.cfg.in`, `llvm-libc++abi-static.cfg.in` and `llvm-libunwind-static.cfg.in`. It works fine for the builds currently.
> We provide `<lib>_TARGET_INFO=libcxx.test.target_info.LinuxRemoteTI` and `<lib>_EXECUTOR` cmake vars only for these configurations.
> Actually, the tests work without `<lib>_TARGET_INFO` also, but because there is still an appropriate parameter I did keep them there just in case.
>
> So, it looks fine for now I guess.

Oh, awesome, thanks for checking! I have an upcoming patch that will remove some of your CMake variables. I'll ping you on the patch when I update it.

It will only land after we branch for LLVM 15.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126478/new/

https://reviews.llvm.org/D126478