[libcxx-commits] [PATCH] D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14

Thu May 26 11:45:30 PDT 2022

dim added a comment.

In D126462#3540480 <https://reviews.llvm.org/D126462#3540480>, @philnik wrote:

> 

...

>> But for 14.0, which is our trunk/main/head, there is no such ABI promise, therefore we can simply bump libc++.so to .2 now and fix the issue that way. If the upstream libc++ ABI version gets bumped to 2 though, we'll have to bump our .so to .3 I'm afraid, since the ELF soversion doesn't really allow "half-sized" version numbers.
>
> Do you have to bump the version //now// or would it be possible for you to wait maybe one or two months so we can get things sorted out upstream?

We've been carrying the old ABI for a very long time, so in my opinion it should not be too much of a problem to wait a little while longer. That would still entail some work on our side for providing the old .so.1 compat library and such, but bumping only once instead of twice is less disruptive, of course.

However, I am not completely sure how far off FreeBSD 14.0's "freeze" is, e.g. when a stable/14 branch is created, and the main branch is bumped to 15.0. Since FreeBSD 13.1-RELEASE is just out the door, there might still be enough time. @emaste you might be more aware of any proposed FreeBSD release schedule?

> https://github.com/llvm/llvm-project/blob/0be0a53df65cb402359c257922d80ab93d86fb40/libcxx/include/__config#L59-L118 is the list of current ABI-breaking changes.

Well, I find that list quite long and impressive already! But whether it is enough for an ABI bump is up to the community of course.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126462/new/

https://reviews.llvm.org/D126462