[libcxx-commits] [PATCH] D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxxabi/test/libcxxabi/test/config.py:52
         if not self.get_lit_bool('enable_threads', True):
             self.cxx.compile_flags += ['-D_LIBCXXABI_HAS_NO_THREADS']
+            self.config.available_features.add('libcpp-has-no-threads')
----------------
Ah, so `_LIBCXXABI_HAS_NO_THREADS` is handled by the old-style config but not the new one.




================
Comment at: libcxxabi/test/test_fallback_malloc.pass.cpp:18
+#ifdef TEST_HAS_NO_THREADS
+# define _LIBCXXABI_HAS_NO_THREADS
+#endif
----------------
ldionne wrote:
> EricWF wrote:
> > Doesn't the LIT config handle defining this macro?
> It doesn't, and I don't think it should, since this is effectively a macro that *should* only matter when compiling the libc++abi sources.
Are you sure. See the above added inline comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125242/new/

https://reviews.llvm.org/D125242