[libcxx-commits] [PATCH] D126342: [libunwind] Factor out sigreturn check condition. NFC

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard accepted this revision.
rprichard added inline comments.


================
Comment at: libunwind/src/UnwindCursor.hpp:35
+    (defined(_LIBUNWIND_TARGET_AARCH64) || defined(_LIBUNWIND_TARGET_S390X))
+#define _LIBUNWIND_CHECK_LINUX_SIGRETURN
+#endif
----------------
nit: For consistency, I wonder if this should define `_LIBUNWIND_CHECK_LINUX_SIGRETURN` to `1` instead of empty. `__libunwind_config.h` defines most of its boolean `_LIBUNWIND_*` macros to `1`. (Exceptions I see include `_LIBUNWIND_ARM_EHABI` and `_LIBUNWIND_TARGET_I386`.)

Alternately, the headers could define the boolean macros to empty, because we're always using `defined(...)` to test whether they're set.

I'm also happy with this patch as-is, though.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126342/new/

https://reviews.llvm.org/D126342