[libcxx-commits] [PATCH] D125331: [libc++] Make sure that all headers can be included with modules enabled

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/include/barrier:54
+#include <limits>
 #ifndef _LIBCPP_HAS_NO_TREE_BARRIER
 # include <memory>
----------------
EricWF wrote:
> As a side note, I really don't love that headers are conditionally included. It just makes things weirder for our users, and even for us (it's an easy way to write portability bugs).
> 
> 
I agree -- I think we should only conditionally include headers when including the headers *doesn't* work (i.e. including `iostream` on a platform that doesn't have localization). Adding a TODO to my list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125331/new/

https://reviews.llvm.org/D125331