[libcxx-commits] [PATCH] D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

I'm not sure I understand what "from scratch" means given this patch, but I don't need to understand to see that to LGTM it. LGTM once the inline comments are addressed.



================
Comment at: libcxxabi/test/libcxxabi/test/config.py:52
         if not self.get_lit_bool('enable_threads', True):
             self.cxx.compile_flags += ['-D_LIBCXXABI_HAS_NO_THREADS']
+            self.config.available_features.add('libcpp-has-no-threads')
----------------
If we're using the same feature name for libc++ and libc++abi, I assume that means that they cannot vary independently. 

If so, should we just use `_LIBCPP_HAS_NO_THREADS` instead, and kill the `LIBCXXABI_HAS_NO_THREADS` macro?


================
Comment at: libcxxabi/test/test_exception_storage.pass.cpp:17
 
+#include "test_macros.h"
+
----------------
Is this the same `test_macros.h` header as libc++, or a different one?




================
Comment at: libcxxabi/test/test_fallback_malloc.pass.cpp:17
+#include "test_macros.h"
+#ifdef TEST_HAS_NO_THREADS
+# define _LIBCXXABI_HAS_NO_THREADS
----------------
This makes the test non-modular. Could you add an // XFAIL or UNSUPPORTED to that affect?


================
Comment at: libcxxabi/test/test_fallback_malloc.pass.cpp:18
+#ifdef TEST_HAS_NO_THREADS
+# define _LIBCXXABI_HAS_NO_THREADS
+#endif
----------------
Doesn't the LIT config handle defining this macro?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125242/new/

https://reviews.llvm.org/D125242