[libcxx-commits] [PATCH] D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Thanks for the fix!



================
Comment at: libcxx/include/type_traits:3510
       _IsNotSame<_Result, __nat>::value,
-      typename conditional<
-          is_void<_Ret>::value,
-          true_type,
-          is_convertible<_Result, _Ret>
-      >::type,
-      false_type
-  >::type;
+      typename conditional< is_void<_Ret>::value, true_type, __is_core_convertible<_Result, _Ret> >::type,
+      false_type >::type;
----------------
philnik wrote:
> Well, that's a lot shorter. Although I have to say `__is_core_convertible` isn't a very intuitive name. Is there any reason it is called that @EricWF?
I think it refers to the "core language" definition of convertibility rather than the library definition?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125300/new/

https://reviews.llvm.org/D125300