[libcxx-commits] [PATCH] D100504: [libc++abi][AIX] add personality and helper functions for the state table EH

[Xing Xue via Phabricator via libcxx-commits]

xingxue marked 3 inline comments as done.
xingxue added inline comments.


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:63
+
+namespace __cxxabiv1
+{
----------------
MaskRay wrote:
> 
Fixed, thanks!


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:66
+
+extern "C"
+{
----------------
MaskRay wrote:
> 
Fixed, thanks!


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:70
+// Macros for debugging the state table parsing.
+#  ifdef NDEBUG
+#    define _LIBCXXABI_TRACE_STATETAB(msg, ...)
----------------
MaskRay wrote:
> `#ifdef NDEBUG`.
> 
> It is not nested, and should have spaces between `#` and `ifdef`.
Fixed, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100504/new/

https://reviews.llvm.org/D100504