[libcxx-commits] [PATCH] D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.

Fri May 20 07:11:27 PDT 2022

danielkiss marked an inline comment as done.
danielkiss added a comment.

In D123692#3527595 <https://reviews.llvm.org/D123692#3527595>, @ldionne wrote:

> c218fd3d7d3764eb123c8429bbcd33bacfe2e633 <https://reviews.llvm.org/rGc218fd3d7d3764eb123c8429bbcd33bacfe2e633> added `libcxxabi/test/native/AArch64/ra_sign_state.pass.cpp` -- was that intended, or should it have been added to `libunwind/test/[...]`? It also started failing in the CI in the `-fno-exceptions` configuration -- I think it is just missing a `XFAIL` so I'll add it, but please investigate whether the file needs to be moved (I think it does).

Tests in libunwind can't depend on libcxx (failed in llvm-libunwind-static.cfg.in) so the test is moved to libcxxabi, because test test case needs exception. (simple backtrace won't trigger the problem)

> If so, please make sure to open a code review for that change since it will cause our pre-commit CI to run, and please don't commit the change until it is green :-).

Sure will do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123692/new/

https://reviews.llvm.org/D123692