[libcxx-commits] [PATCH] D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI

[Xing Xue via Phabricator via libcxx-commits]

xingxue added inline comments.


================
Comment at: libunwind/test/configs/ibm-libunwind-shared.cfg.in:23
+config.substitutions.append(('%{exec}',
+    '%{executor} --execdir %T --env LIBPATH=%{lib} -- '
+))
----------------
MaskRay wrote:
> Why is `LIBPATH` needed?
The AIX linker/loader does not support `$ORIGIN` so setting env var LIBPATH makes sure the loader loads libraries from the directories it specifies.


================
Comment at: libunwind/test/configs/ibm-libunwind-shared.cfg.in:35
+)
+
----------------
MaskRay wrote:
> delete the trailing blank line
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126017/new/

https://reviews.llvm.org/D126017