[libcxx-commits] [PATCH] D124346: [libc++] Complete the implementation of N4190

Thu May 19 08:10:20 PDT 2022

philnik marked 4 inline comments as done.
philnik added inline comments.

================
Comment at: libcxx/include/__config:1245
 #endif

 #if defined(_LIBCPP_HAS_NO_PRAGMA_PUSH_POP_MACRO)
----------------
ldionne wrote:
> For the types that are specified as inheriting from `unary_function`/`binary_function`, can you please add a test to check that we inherit from them in C++ <= 14?
There are already tests for all of them. They haven't been guarded with `_LIBCPP_ABI_NO_BINDER_BASES`.

================
Comment at: libcxx/include/__functional/binder2nd.h:24

 template <class __Operation>
 class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX11 binder2nd
----------------
ldionne wrote:
> Unrelated, but we should rename this to `_Operation` (elsewhere too). Can you make a NFC commit?
I've added a TODO on my list.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124346/new/

https://reviews.llvm.org/D124346