[libcxx-commits] [PATCH] D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.

Thu May 19 00:44:01 PDT 2022

danielkiss marked an inline comment as done.
danielkiss added inline comments.

================
Comment at: libunwind/src/DwarfInstructions.hpp:180
+  if (regloc.location == CFI_Parser<A>::kRegisterUnused)
+    raSignState = regloc.value;
+  else
----------------
Mordante wrote:
> In the libc++ pre-commit CI I see some failures https://buildkite.com/llvm-project/libcxx-ci/builds/10887#fb4448a3-a3f7-4a0a-8997-ccbdfd1b35a3 
> ```
> /home/tcwg-buildbot/worker/linaro-aarch64-libcxx-01/llvm-project/libcxx-ci/libunwind/src/DwarfInstructions.hpp:180:26: error: implicit conversion changes signedness: 'int64_t' (aka 'long') to 'libunwind::DwarfInstructions<libunwind::LocalAddressSpace, libunwind::Registers_arm64>::pint_t' (aka 'unsigned long') [-Werror,-Wsign-conversion]
>     raSignState = regloc.value;
> ```
> I didn't verify this patch caused it, but it seems very likely to me.
Yes, it did. Revert reverted this too, so it is relanded.
https://github.com/llvm/llvm-project/commit/6716e2055ddeac304f47adc5ae39086381016ba7

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123692/new/

https://reviews.llvm.org/D123692