[libcxx-commits] [PATCH] D124740: [libc++] Granularize algorithm benchmarks

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with my comment applied.



================
Comment at: libcxx/benchmarks/algorithms/common.h:244
+
+#define LIBCPP_ALGORITHMS_BENCHMARK_MAIN(...)                                                                          \
+  int main(int argc, char** argv) {                                                                                    \
----------------
I think I'd rather not introduce this macro since the other benchmarks don't use it. IMO the cost of this duplication is not enough to try avoiding it with a macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124740/new/

https://reviews.llvm.org/D124740