[libcxx-commits] [PATCH] D125910: [libc++] Improve error messages for disabled modes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Nice user improvement!



================
Comment at: libcxx/include/filesystem:264
 #if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY)
-# error "The Filesystem library is not supported since libc++ has been configured with LIBCXX_ENABLE_FILESYSTEM disabled"
+# error "The <filesystem> library is not supported since libc++ has been configured without support for a filesystem."
 #endif
----------------
In general I like the approach to make errors easier to understand. I just wonder would it be useful to keep the CMake flag? Something along the lines of the suggested edit.



================
Comment at: libcxx/include/future:2435
 
 #endif // !_LIBCPP_HAS_NO_THREADS
 
----------------
`<shared_mutex>` and `<thread>` seem to have a similar issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125910/new/

https://reviews.llvm.org/D125910