[libcxx-commits] [PATCH] D125813: [libc++] Removes __cpp_lib_monadic_optional.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:496
     "name": "__cpp_lib_optional",
-    "values": { "c++17": 201606 },
+    "values": { "c++17": 201606, "c++2b": 202110 },
     "headers": ["optional"],
----------------
Mordante wrote:
> philnik wrote:
> > The LWG issue says that `202106L` is replaced with `202110L`. Do you know what `202106L` is?
> ISO Standards only have one version, when a new version is released older versions are obsolete. In C++17 optional was added to the Standard with `202106L` (I didn't validate that). Now the Standard updates it to `202110L`. In libc++ we still want to use `202106L` when compiled with C++17 or C++20. When the user uses C++2b it should be `202110L`.
> 
> The same happened to `__cpp_lib_string_view`.
> 
I understand that part. I wanted to know if we have implemented the feature that bumped the version to `202106L`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125813/new/

https://reviews.llvm.org/D125813