[libcxx-commits] [PATCH] D125184: [libc++] fix std::to_string() crashing in debug mode

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D125184#3516866 <https://reviews.llvm.org/D125184#3516866>, @llunak wrote:

> In D125184#3516573 <https://reviews.llvm.org/D125184#3516573>, @philnik wrote:
>
>> My main problem with this approach is that we add symbols to the dylib which we //know// will be obsolete in a few months, but we have to keep them forever due to ABI concerns.
>
> In D122941 <https://reviews.llvm.org/D122941> you both say that debug mode does not have stable ABI. Moreover whatever it'll be exactly that you'll do to make these obsolete will presumably break ABI too.

We are saying that the new debug should use the unstable ABI. While we don't guarantee ABI stability for the current debug mode, the ABI has been stable for a long time. This means that we would break users who depend on this. The new debug mode won't break the ABI of the current debug mode AFAIK. I don't know if we would actually keep these functions in the dylib, but I fear that will be the case if we add them silently now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125184/new/

https://reviews.llvm.org/D125184