[libcxx-commits] [PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D125683#3516883 <https://reviews.llvm.org/D125683#3516883>, @ldionne wrote:

> In D125683#3515675 <https://reviews.llvm.org/D125683#3515675>, @mstorsjo wrote:
>
>> It looks like this patch still lacks compatibility handling for all external users that are setting this option, which need to be able to set the option in this way at least until after the 15.0.0 release.
>
> What would you think about erroring out if someone is still passing `LIBCXX_STATICALLY_LINK_ABI_IN_{SHARED|STATIC}_LIBRARY`? Sure, we can try to support both for a while, but I wonder whether there's any actual benefit to balance the added complexity. Concretely, I suspect this impacts very few people, and the fix is really simple. And if we error out during the CMake step, we don't risk breaking anyone silently.

I guess that's better than silently (well, cmake warns, but it's easy to miss) no longer doing what it used to, but it's not ideal IMO. I do my continuous build testing with a build invocation that also works for the latest release - but with the suggested transition, there's no single build invocation that works for both the main branch and the 14.x release. I guess I could manage though, but I'd prefer a smoother upgrade path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125683/new/

https://reviews.llvm.org/D125683