[libcxx-commits] [PATCH] D125704: [libc++] Make to_chars base 10 header only.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/charconv:108-111
-namespace __itoa {
-_LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_FUNC_VIS char* __u64toa(uint64_t __value, char* __buffer) noexcept;
-_LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_FUNC_VIS char* __u32toa(uint32_t __value, char* __buffer) noexcept;
-} // namespace __itoa
----------------
philnik wrote:
> Since we have to keep the functions in the dylib forever anyways, why not use them?
Since I want to remove the code from the dylib I thought it was easier to use a new name instead of using the `gnu_inline` attribute. 
```
* The code in the dylib can switch to using the header implementation. This allows removing the code duplicated in the header and the dylib.
```
We can even removed the code in the dylib for ABI v2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125704/new/

https://reviews.llvm.org/D125704