[libcxx-commits] [PATCH] D125608: [libc++] Implement ranges::is_sorted{, _until}

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM, except for the CI failure. I'll only approve it on my name to give others some time to have a look too.



================
Comment at: libcxx/include/__algorithm/ranges_is_sorted.h:46
+                                          __comp,
+                                          __proj) == ranges::end(__range);
+  }
----------------
philnik wrote:
> Mordante wrote:
> > This looks sensible, however it seems the Standard doesn't specify this overload. Is there an LWG issue?
> I'm not sure what you mean. It's both in the current standard and in the one ranges proposal. Did you just miss it? It's right after http://eel.is/c++draft/alg.sort#is.sorted-4.
Nevermind, it seems I missed http://eel.is/c++draft/algorithms#requirements-15, which makes the wording clear. (Unless you want to be pedantic, then `ranges::end(__range)` seems not to be specified.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125608/new/

https://reviews.llvm.org/D125608