[libcxx-commits] [PATCH] D125184: [libc++] fix std::to_string() crashing in debug mode

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D125184#3514315 <https://reviews.llvm.org/D125184#3514315>, @llunak wrote:

> In D125184#3514289 <https://reviews.llvm.org/D125184#3514289>, @Mordante wrote:
>
>> I agree this is worth fixing, but I'm not convinced that this solution is safe and doesn't lead to ODR violations when different translation units are compiled with different values of `_LIBCPP_DEBUG_LEVEL`.
>
> As you can see in the abi check lists, the debug functions are in a different namespace, so technically they are different functions. (You actually cannot the see to_string() functions themselves there, only the helpers, but any out-of-line copies of those would get the same treatment.)

I'm concerned regarding the difference between`_LIBCPP_FUNC_VIS` and `_LIBCPP_HIDE_FROM_ABI` for the `to_string` function. I'm not sure whether that may cause an ODR violation. I don't expect issues with the new functions in the `__debug` namespace.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125184/new/

https://reviews.llvm.org/D125184