[libcxx-commits] [PATCH] D125704: [libc++] Make to_chars base 10 header only.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The functions to_chars and from_chars should offer 128-bit support. This
is the first step to implement 128-bit version of to_chars. Before
implementing 128-bit support the current code will be polished.

This moves the code from the dylib to the header in prepartion of

P2291 <https://reviews.llvm.org/P2291> "Add Constexpr Modifiers to Functions to_chars and from_chars for
Integral Types in <charconv> Header"

Note some more cleanups will be done in follow-up commits

- Remove the _LIBCPP_AVAILABILITY_TO_CHARS from to_chars. With all code in the header the availablilty macro is no longer needed. This requires enabling the unit tests for additional platforms.
- The code in the dylib can switch to using the header implementation. This allows removing the code duplicated in the header and the dylib.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125704

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__charconv/tables.h
  libcxx/include/__charconv/to_chars_base_10.h
  libcxx/include/charconv
  libcxx/include/module.modulemap
  libcxx/test/libcxx/private_headers.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125704.429760.patch
Type: text/x-patch
Size: 10145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220516/257d2aa0/attachment-0001.bin>