[libcxx-commits] [PATCH] D125184: [libc++] fix std::to_string() crashing in debug mode

Luboš Luňák via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 14 22:20:27 PDT 2022


llunak updated this revision to Diff 429514.
llunak retitled this revision from "[libc++] work around std::to_string() and _LIBCPP_DEBUG == 1  crashing" to " [libc++] fix std::to_string() crashing in debug mode".
llunak edited the summary of this revision.
llunak added a comment.
Herald added a subscriber: mgorny.

I'd like to give this another try after all. AFAICT using an inline namespace solves the problem of ABI for non-debug mode, as this way it is not affected at all, while the debug mode std::to_string() is now properly a separate function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125184/new/

https://reviews.llvm.org/D125184

Files:
  libcxx/CMakeLists.txt
  libcxx/include/string
  libcxx/src/string.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125184.429514.patch
Type: text/x-patch
Size: 8672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220515/95e89ae2/attachment-0001.bin>


More information about the libcxx-commits mailing list