[libcxx-commits] [PATCH] D125618: [libc++][test] Verify std::views::drop and std::views::join are CPOs

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 14 15:03:55 PDT 2022


jloser created this revision.
jloser added reviewers: Mordante, ldionne, var-const, philnik.
Herald added a project: All.
jloser requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

`std::views::drops` and `std::views::join` have been implemented, but the tests
verifying the CPOs for them are been implemented is still commented out.
Uncomment them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125618

Files:
  libcxx/test/std/library/description/conventions/customization.point.object/cpo.compile.pass.cpp


Index: libcxx/test/std/library/description/conventions/customization.point.object/cpo.compile.pass.cpp
===================================================================
--- libcxx/test/std/library/description/conventions/customization.point.object/cpo.compile.pass.cpp
+++ libcxx/test/std/library/description/conventions/customization.point.object/cpo.compile.pass.cpp
@@ -42,7 +42,7 @@
 }
 
 int a[10];
-//int arrays[10][10];
+int arrays[10][10];
 //std::pair<int, int> pairs[10];
 
 // [concept.swappable]
@@ -86,11 +86,11 @@
 static_assert(test(std::views::all, a));
 static_assert(test(std::views::common, a));
 static_assert(test(std::views::counted, a, 10));
-//static_assert(test(std::views::drop, a, 10));
+static_assert(test(std::views::drop, a, 10));
 //static_assert(test(std::views::drop_while, a, [](int x){ return x < 10; }));
 //static_assert(test(std::views::elements<0>, pairs));
 static_assert(test(std::views::filter, a, [](int x){ return x < 10; }));
-//static_assert(test(std::views::join, arrays));
+static_assert(test(std::views::join, arrays));
 //static_assert(test(std::views::split, a, 4));
 static_assert(test(std::views::lazy_split, a, 4));
 static_assert(test(std::views::reverse, a));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125618.429489.patch
Type: text/x-patch
Size: 1218 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220514/d36ab1a4/attachment.bin>


More information about the libcxx-commits mailing list