[libcxx-commits] [PATCH] D121530: [libc++][format] Implement format-string.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/format:515
+};
+// These aliases fail on both MinGW and clang-cl. Since the aliases are
+// exposition only it's not a big issue. However P2508 will use a similar alias
----------------
It seems `__format_string` is Microsoft annotation which caused the compilation failures. So by naming them different would solve the issue. This means the name becomes a bit awkward for the libc++ naming scheme. I expect P2508 to be accepted soon, which changes the names to `format_string` and `wformat_string`. For now I prefer to keep the work-around and fix it once P2508 is voted in. (This paper aims to be applied to C++20.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121530/new/

https://reviews.llvm.org/D121530