[libcxx-commits] [PATCH] D125606: [libc++][format] Improve string formatters

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:1538
+  __sign __sign_ : 2 {__sign::__default};
+  uint8_t __alternate_form_ : 1 {false};
+  uint8_t __zero_padding_ : 1 {false};
----------------
philnik wrote:
> Why not use `bool`?
That will most likely change the size of the object on Windows. (Note that the underlying type of the enum classes is an uint8_t too.) I can test this after the Windows build is green.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125606/new/

https://reviews.llvm.org/D125606