[libcxx-commits] [PATCH] D125393: [runtimes] Introduce object libraries

Fri May 13 14:01:15 PDT 2022

mstorsjo accepted this revision.
mstorsjo added a comment.

In D125393#3511412 <https://reviews.llvm.org/D125393#3511412>, @ldionne wrote:

> This should address review comments. Please LMK what you think.

This seems to work fine for me, thanks! (But please check that the full CI run works of course.) I didn't do a full review in detail, but from what I've looked at, it seems good to me!

In D125393#3512071 <https://reviews.llvm.org/D125393#3512071>, @phosek wrote:

> See the discussion on D116689 <https://reviews.llvm.org/D116689>. What @mstorsjo would like to do is to build with `LIBCXXABI_ENABLE_SHARED=OFF` and `LIBCXXABI_ENABLE_STATIC=OFF`, but still merge libcxxabi into libcxx.

Well so far I do build with `LIBCXXABI_ENABLE_STATIC=ON` (otherwise I wouldn't have a static library to merge into libcxx) - it's just `LIBCXXABI_ENABLE_SHARED` which I have to disable because it's not possible to link. But as I don't need the static libcxxabi library as a final build product, I guess being able to disable both "product parts" of libcxxabi would be nice!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125393/new/

https://reviews.llvm.org/D125393