[libcxx-commits] [PATCH] D97705: [libc++] Improve std::to_chars for base != 10.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This looks sensible to me.



================
Comment at: libcxx/include/charconv:508
+          typename enable_if<(sizeof(_Tp) < sizeof(unsigned)), int>::type = 0>
+_LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_HIDE_FROM_ABI to_chars_result
+__to_chars_integral(char* __first, char* __last, _Tp __value) {
----------------
I don't think we need `_LIBCPP_AVAILABILITY_TO_CHARS` here, since this is all implemented in the headers. Or did I miss a dependency on the dylib?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97705/new/

https://reviews.llvm.org/D97705