[libcxx-commits] [PATCH] D122604: [demangler] Simplify OutputBuffer initialization

[Tomasz Miąsko via Phabricator via libcxx-commits]

tmiasko accepted this revision.
tmiasko added a comment.

Looks good.

Nit: reviewing from the perspective of OutputBuffer starting empty, the OutputBuffer::prepend might need an extra check to avoid passing nullptr to memmove / memcpy, in an unusual case an empty string were to be prepended to an empty output buffer.

As far as CI is concerned, if you are logged in the Phabricator, then following `completed remote builds in B164300: Diff 429222` -> `pre-merge checks` -> plain text URL `https://buildkite.com/llvm-project/diff-checks/builds/104149` shows:

> Attention! D124524 <https://reviews.llvm.org/D124524> is one of the dependencies of the target revision D122604 <https://reviews.llvm.org/D122604>.
> No testing is possible because we couldn't apply the patch.

Looks like there is now a stale parent revision D124524 <https://reviews.llvm.org/D124524> and patch fails to apply.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122604/new/

https://reviews.llvm.org/D122604