[libcxx-commits] [PATCH] D124519: [libcxx] Switch __cxx_contention_t to int32_t on 32 bit AIX

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D124519#3497376 <https://reviews.llvm.org/D124519#3497376>, @mstorsjo wrote:

> @ldionne Would you happen to know what the implications and tradeoffs involved in `__cxx_contention_t` are, and why so far linux used `int32_t` while everything else used `int64_t`, and whether it is reasonable to switch 32 bit AIX to `int32_t`?

Olivier tells me that the contention type should be the platform's ideal Futex type. On Linux that is 32 bits (regardless of 32/64 bit pointer size), but for other platforms it would make sense to make it pointer-sized. If this is fine with @daltenty , I think this is good to go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124519/new/

https://reviews.llvm.org/D124519