[libcxx-commits] [PATCH] D125393: [runtimes] Introduce object libraries

Thu May 12 00:56:51 PDT 2022

mstorsjo added a comment.

In D125393#3507435 <https://reviews.llvm.org/D125393#3507435>, @phosek wrote:

> As mentioned in D116689 <https://reviews.llvm.org/D116689>, the `EXCLUDE_FROM_ALL` is going to require more cleanup throughout LLVM so I'd suggest making that change as a follow up.

Ah, sorry, I missed to pick up that detail there. As we do have the mingw-dll configuration in libcxx CI (which gets broken by this patch as-is), we need to fix this in one way or another before we can land this though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125393/new/

https://reviews.llvm.org/D125393