[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

Wed May 11 13:00:43 PDT 2022

phosek added a comment.

In D116689#3504337 <https://reviews.llvm.org/D116689#3504337>, @phosek wrote:

> In D116689#3502709 <https://reviews.llvm.org/D116689#3502709>, @mstorsjo wrote:
>
>> In D116689#3502026 <https://reviews.llvm.org/D116689#3502026>, @phosek wrote:
>>
>>> I wonder if we could simplify things by always building `cxxabi_static_objects` and `cxxabi_shared_objects` but marking them as `EXCLUDE_FROM_ALL`?
>>
>> That's probably the best solution for that - thanks!
>
> I've realized that this also going to simplify our build so I like that direction. It's not entirely straightforward though because there are currently various parts of the build that assume that either static or shared libcxxabi is being built which need to be reworked.

I got everything to build, but there are some open questions. For example, if we only build libcxxabi objects and neither of the libraries, should we skip libcxxabi tests, or shall we run them but use libcxx (if libcxxabi objects are being linked into libcxx)?

In D116689#3506393 <https://reviews.llvm.org/D116689#3506393>, @ldionne wrote:

> Since this conflicts heavily with D120727 <https://reviews.llvm.org/D120727>, I proposed a way forward that implements this patch on top of D120727 <https://reviews.llvm.org/D120727>. See D125393 <https://reviews.llvm.org/D125393>

I'm fine going with your change if we can land it shortly after D120727 <https://reviews.llvm.org/D120727> since there's other follow up work I'd like to do that I mentioned above.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689