[libcxx-commits] [PATCH] D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`."

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 11 12:29:11 PDT 2022


Mordante added inline comments.


================
Comment at: libcxx/include/__random/binomial_distribution.h:30
 {
-    static_assert(__libcpp_random_is_valid_inttype<_IntType>::value, "IntType must be an integer type larger than char");
 public:
----------------
If we decide to reenable this can you add comments to the class what we accept `bool` and `char` as an extension. That would avoid future confusion.

Still we first need to decide whether or allow the extension.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125283/new/

https://reviews.llvm.org/D125283



More information about the libcxx-commits mailing list