[libcxx-commits] [PATCH] D125221: [libc++] Fix conjunction/disjunction and mark a few LWG issues as complete

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/utilities/meta/meta.logical/conjunction.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
I think we are missing tests for `conjunction` and `disjunction` with types that don't have a `::value` but should never be instantiated because of short-circuiting.


================
Comment at: libcxx/test/std/utilities/meta/meta.logical/conjunction.compile.pass.cpp:70
+
+static_assert(std::conjunction<MyOtherSpecialTrueType, MySpecialTrueType>::MySpecial == 23);
+static_assert(std::conjunction<MySpecialTrueType, MyOtherSpecialTrueType>::MySpecial == 46);
----------------
We should be testing that `is_base_of` instead, since that's what the spec requests. Same for `disjunction`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125221/new/

https://reviews.llvm.org/D125221