[libcxx-commits] [PATCH] D124906: [libc++][NFC] Add more tests to `move_{iterator, sentinel}`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with passing tests (the issue looks fairly benign) and after you've investigated whether we can test with more archetypes. Thanks for adding these tests!



================
Comment at: libcxx/test/std/iterators/predef.iterators/move.iterators/move.iter.ops/move.iter.op.-/sentinel.pass.cpp:83-84
+  test_one<CustomIt>();
+  test_one<cpp17_input_iterator<int*>>();
+  test_one<forward_iterator<int*>>();
+  test_one<bidirectional_iterator<int*>>();
----------------
What about `cpp20_input_iterator`? And `output_iterator`? I think it may be possible to improve test coverage here and elsewhere by adding tests with a couple more archetypes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124906/new/

https://reviews.llvm.org/D124906