[libcxx-commits] [PATCH] D120727: [libc++] Overhaul how we select the ABI library

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

I gave it a quick readthrough, but I don't think I can give a qualified review of the bulk of it... I noticed a couple minor details though.



================
Comment at: libcxx/CMakeLists.txt:260
   else()
-    set(LIBCXX_CXX_ABI_LIBNAME "default")
+    set(LIBCXX_CXX_ABI "libcxxabi")
   endif()
----------------
Couldn't these lines be replaced with just a `set(LIBCXX_CXX_ABI ${LIBCXX_DEFAULT_ABI_LIBRARY})`?


================
Comment at: libcxxabi/CMakeLists.txt:201
 endif()
+message(STATUS "Using libc++abi testing configuration: ${LIBCXXABI_TEST_CONFIG}")
 set(LIBCXXABI_TEST_PARAMS "" CACHE STRING
----------------
Unrelated to the rest of the patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120727/new/

https://reviews.llvm.org/D120727