[libcxx-commits] [PATCH] D125268: [libc++abi][NFC] Refactor exception type demangling into a separate function

[Nathan Sidwell via Phabricator via libcxx-commits]

urnathan added inline comments.


================
Comment at: libcxxabi/src/cxa_default_handlers.cpp:31-33
+    const char* result = __cxxabiv1::__cxa_demangle(str, buf, &len, &status);
+    if (status != 0)
+        return str;
----------------
```
if (auto *res = ...)
  return res;
else
  return str;
```
?  No need to pass in status -- we don't care why it can't demangle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125268/new/

https://reviews.llvm.org/D125268