[libcxx-commits] [PATCH] D125156: [libc++][ranges] Implement `views::drop`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const marked an inline comment as done.
var-const added inline comments.


================
Comment at: libcxx/include/__ranges/drop_view.h:158-160
+inline constexpr bool __store_size<subrange<_Iter, _Sent, _Kind>> =
+    // The definition of `subrange::StoreSize` (which is exposition-only and private).
+    _Kind == subrange_kind::sized && !sized_sentinel_for<_Sent, _Iter>;
----------------
ldionne wrote:
> To avoid those getting out of sync, perhaps we should instead make `_StoreSize` public and access it directly from here as `subrange::_StoreSize`?
Done, thanks. I was thinking the same thing but was concerned about making this implementation detail public; on the other hand, with the "mangled" internal name it should be clear it shouldn't be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125156/new/

https://reviews.llvm.org/D125156