[libcxx-commits] [PATCH] D124789: [libc++] Find a clang-format everybody is happy with

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I just went to the formatted files and in general I'm quite happy with it. Some concept related parts still don't look great, but I expect most/all of them can be fixed with extra parens.

I have a preference to stay as close to LLVM style as possible.



================
Comment at: libcxx/.clang-format:59
+BinPackParameters: false
+BreakBeforeBinaryOperators: All
+BreakBeforeConceptDeclarations: true
----------------
This seems to deviate from LLVM style, why do we want to deviate here?


================
Comment at: libcxx/include/__ranges/lazy_split_view.h:81
+  _LIBCPP_HIDE_FROM_ABI lazy_split_view()
+    requires default_initializable<_View> && default_initializable<_Pattern>
+  = default;
----------------
This looks quite bad, but I expect it's a clang-format error. Does it become better with this change


================
Comment at: libcxx/include/__ranges/lazy_split_view.h:93
+        // TODO(varconst): use `views::single` once it's implemented.
+        ,
+        __pattern_(ranges::single_view(std::move(__e))) {}
----------------
it looks like this needs manual intervention, but probably one time only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124789/new/

https://reviews.llvm.org/D124789