[libcxx-commits] [PATCH] D125156: [libc++][ranges] Implement `views::drop`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: libcxx/include/__ranges/drop_view.h:158-160
+inline constexpr bool __store_size<subrange<_Iter, _Sent, _Kind>> =
+    // The definition of `subrange::StoreSize` (which is exposition-only and private).
+    _Kind == subrange_kind::sized && !sized_sentinel_for<_Sent, _Iter>;
----------------
To avoid those getting out of sync, perhaps we should instead make `_StoreSize` public and access it directly from here as `subrange::_StoreSize`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125156/new/

https://reviews.llvm.org/D125156