[libcxx-commits] [PATCH] D125184: [libc++] work around std::to_string() and _LIBCPP_DEBUG == 1 crashing

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

I don't think that this approach is better. Now if you pass in a `long long` it will crash , but no other integral type will. That's just as unexpected as the current state of things, maybe even more. If you want to know a bit more about the debug mode plans you can read D122941 <https://reviews.llvm.org/D122941>.



================
Comment at: libcxx/include/string:4557
+
+static _LIBCPP_ALWAYS_INLINE string to_string(int __val)
+{
----------------
These functions should neither be `_LIBCPP_ALWAYS_INLINE` nor `static`. They should be marked `_LIBCPP_HIDE_FROM_ABI`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125184/new/

https://reviews.llvm.org/D125184