[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D116689#3497481 <https://reviews.llvm.org/D116689#3497481>, @mstorsjo wrote:

> @phosek Do you have time to pick this up and complete it? It'd be essential for a build cleanup for Windows - but the patch itself is a bit too far outside of my cmake-fu.

I have uploaded an updated version which simplifies the implementation and seems to be working for me locally although I haven't done extensive testing yet.

> For the mingw builds, the essential component is that `cxx_shared` uses `cxxabi_objects_shared`. However, the tricky thing is that `cxxabi_shared` isn't built (it's disabled, as it can't be linked as it has inverse dependencies on symbols provided by libcxx), but the `cxxabi_objects_shared` component still would need to be built).

Is the current implementation sufficient for your needs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689