[libcxx-commits] [PATCH] D124739: [libc++] Add Mathematical Special Functions status page

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/docs/Status/MathematicalSpecialFunctions.rst:15
+
+This document contains the status of the C++17 Mathematical Special Functions implementation in libc++.
+
----------------
philnik wrote:
> Mordante wrote:
> > I think it would be good to add a link to `p0226r1` here.
> I think adding a link to https://wg21.link/sf.cmath would be a lot more helpful, since `P0226R1` doesn't actually list the changes.
True, I didn't see that during my initial review. I still think the link is useful since the paper adds a feature-test macro. 
I don't mind a link to `sf.cmath`, but I don't see that as required. You already added nice links for all functions in this section. 


================
Comment at: libcxx/docs/Status/MathematicalSpecialFunctionsProjects.csv:1
+Section,Description,Complete
+| `[sf.cmath.assoc.laguerre] <https://wg21.link/sf.cmath.assoc.laguerre>`_,"assoc_laguerre, assoc_laguerref, assoc_laguerrel",""
----------------
philnik wrote:
> Mordante wrote:
> > Why not use `Section, Description,Dependencies,Assignee,Complete` like most other status pages?
> It feels to me like we don't actually use the assignee part in the other status pages very well. We also don't have an assignee field for the main papers and they are just fine. I don't think dependencies are necessary since the functions don't depend on anything AFAICT.
Fair point, it was mainly for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124739/new/

https://reviews.llvm.org/D124739