[libcxx-commits] [PATCH] D124695: [libc++] Avoid a Microsoft SAL macro.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 6 09:35:41 PDT 2022


ldionne added inline comments.


================
Comment at: libcxx/include/__functional/perfect_forward.h:59-62
+      noexcept(_Op()(_VSTD::get<_Idx>(__bound_args_)..., _VSTD::forward<_Args>(__args)...)))
+      -> decltype(_Op()(_VSTD::get<_Idx>(__bound_args_)..., _VSTD::forward<_Args>(__args)...)) {
+    return _Op()(_VSTD::get<_Idx>(__bound_args_)..., _VSTD::forward<_Args>(__args)...);
+  }
----------------
I am not thrilled by this reformatting. There is a reason why we align things like that. We do it consistently everywhere so that we can `grep` more easily and change these write-it-three-times if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124695/new/

https://reviews.llvm.org/D124695



More information about the libcxx-commits mailing list