[libcxx-commits] [PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

[Sam McCall via Phabricator via libcxx-commits]

sammccall added a subscriber: ldionne.
sammccall added a comment.

In D121838#3470478 <https://reviews.llvm.org/D121838#3470478>, @ldionne wrote:

> I think @phosek is the right person to look at this. I looked at it and it seems fine, but I don't know how the runtimes tests are setup well enough to spot an issue if there were one.
>
> Nit: I'd suggest rebasing and re-uploading the patch so that the runtimes CI can run again (and hopefully pass -- there was a flake last time).

OK. I was requesting extra reviews because of the libc++ herald policy.
But since the changes are mechanical/cross-cutting, phosek isn't a libc++ approver, and there hasn't been more activity here I'm going to try to get this landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121838/new/

https://reviews.llvm.org/D121838