[libcxx-commits] [PATCH] D124175: [libcxx] Reject month 0 in get_date/__get_month

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Sorry I missed your update, but LGTM! Please rebase to test the CI is green before landing.



================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp:18
 // GLIBC fails on the zh_CN test.
 // XFAIL: linux
 
----------------
Mordante wrote:
> DavidSpickett wrote:
> > Mordante wrote:
> > > :-( This is not your change, but it basically means these changes aren't tested in most of our CI. I'll create a fix.
> > Yeah I actually tested this on Linux by commenting out that one test case. So I can at least confirm everything else works.
> I just landed D124331, which fixes the tests on Linux. Can you rebase this patch on top of that to see whether the CI is happy too?
Odd this XFAIL should be gone upstream.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124175/new/

https://reviews.llvm.org/D124175