[libcxx-commits] [PATCH] D124993: [libcxx] [test] Fix the nasty_macros test on Windows on ARM/ARM64

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 5 00:24:45 PDT 2022


mstorsjo created this revision.
mstorsjo added a reviewer: Mordante.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This isn't a configuration that we unfortunately can add to
the CI practically at the moment, but I do run the tests
sporadically offline in this configuration.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124993

Files:
  libcxx/test/libcxx/nasty_macros.compile.pass.cpp


Index: libcxx/test/libcxx/nasty_macros.compile.pass.cpp
===================================================================
--- libcxx/test/libcxx/nasty_macros.compile.pass.cpp
+++ libcxx/test/libcxx/nasty_macros.compile.pass.cpp
@@ -107,7 +107,10 @@
 #define C NASTY_MACRO
 #define Cp NASTY_MACRO
 #define Cs NASTY_MACRO
-#define D NASTY_MACRO
+// Windows setjmp.h contains a struct member named 'D' on ARM/AArch64.
+#ifndef _WIN32
+# define D NASTY_MACRO
+#endif
 #define Dp NASTY_MACRO
 #define Ds NASTY_MACRO
 #define E NASTY_MACRO


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124993.427228.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220505/e80b098d/attachment.bin>


More information about the libcxx-commits mailing list