[libcxx-commits] [PATCH] D124555: [libcxx][AIX][z/OS] basic_ios<wchar_t> cannot store fill character WCHAR_MAX

[Chris Bowler via Phabricator via libcxx-commits]

cebowleratibm added inline comments.


================
Comment at: libcxx/test/std/input.output/iostream.format/std.manip/setfill_wcharmax.pass.cpp:13
+// XFAIL: stdlib=libc++ && target=x86_64-pc-windows-msvc
+// XFAIL: stdlib=libc++ && target=x86_64-w64-windows-gnu
+
----------------
philnik wrote:
> Jake-Egan wrote:
> > Instead of XFAILing each target, it might make more sense to add a Lit feature for the new macro, then you can simply do:
> > ```
> > // REQUIRES: libcpp_basic_ios_has_fill_set
> > ```
> > 
> Or just `// REQUIRES: target=zOS-target-triple`. Seems quite wasteful to add a lit feature for a single test.
I thought the test should be opt out rather than opt in because it should legitimately pass.  A user is permitted to set a fill char to WCHARMAX and it should work.  The test will also work on 32 bit targets or targets where wchar_t is signed.

I explicitly called out the failing targets so that they can be on notice that this doesn't work and they can opt into the fix if they like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124555/new/

https://reviews.llvm.org/D124555